fix(core): ensured env vars take precedence over in-code config#2409
Closed
aryamohanan wants to merge 1 commit intofix-config-precedencefrom
Closed
fix(core): ensured env vars take precedence over in-code config#2409aryamohanan wants to merge 1 commit intofix-config-precedencefrom
aryamohanan wants to merge 1 commit intofix-config-precedencefrom
Conversation
aryamohanan
changed the title
aryamohanan
force-pushed
the
fix-config-order
branch
from
2fc5f73 to
15e7bc5
Compare
aryamohanan
added
feature-branch
aryamohanan
changed the title
kirrg001
reviewed
Mar 24, 2026
Contributor
|
I'd suggest to rename the commit to:
And add a TODO for the other packages e.g. collector needs an update too. See normalizeConfig. |
kirrg001
reviewed
Mar 24, 2026
kirrg001
reviewed
Mar 24, 2026
kirrg001
reviewed
Mar 24, 2026
kirrg001
reviewed
Mar 24, 2026
aryamohanan
changed the title
kirrg001
reviewed
Mar 26, 2026
kirrg001
reviewed
Mar 26, 2026
kirrg001
reviewed
Mar 26, 2026
kirrg001
reviewed
Mar 26, 2026
kirrg001
reviewed
Mar 26, 2026
|
This was referenced Mar 26, 2026
aryamohanan
force-pushed
the
fix-config-order
branch
from
2e8eac5 to
0cc1cd0
Compare
Contributor
Author
|
closing this, I will reopen with refactored code. |
Contributor
Author
|
New PR #2478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR addressing configuration precedence.
The goal of this change is to ensure the correct order between environment variables and in-code configuration:
env > in-code
Currently, the precedence between these two sources is mixed. This PR corrects that behavior.
Added missing logging in the configuration file when a config is set.
Scope of This PR
This PR only fixes the precedence between:
Agent configuration precedence will be addressed in separate follow-up PRs.